Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents. #11076

Merged
merged 2 commits into from Feb 13, 2020

Conversation

WeiZhong94
Copy link
Contributor

What is the purpose of the change

This pull request adds description of support 'pip install' to 1.9.x documents.

Brief change log

  • adds description of support 'pip install' to python_table_api.md.
  • adds description of support 'pip install' to python_table_api.zh.md.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e2fc043 (Thu Feb 13 03:34:13 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

PyFlink is available via PyPi and can be easily installed using `pip`.

{% highlight bash %}
$ python -m pip install apache-flink
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the version of 1.9 series, maybe it's better to specify the version, for example:

# install the latest 1.9 version of PyFlink
python -m pip install apache-flink==1.9.*

The command will download the latest 1.9 pyflink.
What do you think?

@@ -30,8 +30,8 @@ under the License.

## 创建一个Python Table API项目

首先,你可以使用你最熟悉的IDE,创建一个Python项目。然后,你需要安装PyFlink包,
请参考[构建PyFlink]({{ site.baseurl }}/zh/flinkDev/building.html#build-pyflink)了解详细信息。
首先,使用您最熟悉的IDE创建一个Python项目。之后执行命令`python -m pip install apache-flink`从PyPI下载安装PyFlink包。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

see [Build PyFlink]({{ site.baseurl }}/flinkDev/building.html#build-pyflink)
for more details about this.
You can begin by creating a Python project and installing the PyFlink package.
PyFlink is available via PyPi and can be easily installed using `pip`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to Pypi

@WeiZhong94
Copy link
Contributor Author

@hequn8128 Thanks for your review! I have updated this PR according to your comments.

@hequn8128
Copy link
Contributor

Merging...

@hequn8128 hequn8128 merged commit e13deed into apache:release-1.9 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants