New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15908][docs] Add description of support 'pip install' to 1.9.x documents. #11076
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit e2fc043 (Thu Feb 13 03:34:13 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
docs/tutorials/python_table_api.md
Outdated
PyFlink is available via PyPi and can be easily installed using `pip`. | ||
|
||
{% highlight bash %} | ||
$ python -m pip install apache-flink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the version of 1.9 series, maybe it's better to specify the version, for example:
# install the latest 1.9 version of PyFlink
python -m pip install apache-flink==1.9.*
The command will download the latest 1.9 pyflink.
What do you think?
@@ -30,8 +30,8 @@ under the License. | |||
|
|||
## 创建一个Python Table API项目 | |||
|
|||
首先,你可以使用你最熟悉的IDE,创建一个Python项目。然后,你需要安装PyFlink包, | |||
请参考[构建PyFlink]({{ site.baseurl }}/zh/flinkDev/building.html#build-pyflink)了解详细信息。 | |||
首先,使用您最熟悉的IDE创建一个Python项目。之后执行命令`python -m pip install apache-flink`从PyPI下载安装PyFlink包。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
docs/tutorials/python_table_api.md
Outdated
see [Build PyFlink]({{ site.baseurl }}/flinkDev/building.html#build-pyflink) | ||
for more details about this. | ||
You can begin by creating a Python project and installing the PyFlink package. | ||
PyFlink is available via PyPi and can be easily installed using `pip`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a link to Pypi
@hequn8128 Thanks for your review! I have updated this PR according to your comments. |
Merging... |
What is the purpose of the change
This pull request adds description of support 'pip install' to 1.9.x documents.
Brief change log
python_table_api.md
.python_table_api.zh.md
.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation