Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16172][build] Add baseline set of allowed unused dependencies #11140

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Feb 19, 2020

Add a baseline of dependencies that we allow to be unused, along with a set of dependencies that we allowed to be used without a declared dependencies.

The purpose here is to ease the analysis of unused dependencies by excluding non-critical dependencies.

You can compare the difference by running mvn dependency:analyze before and after this change.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7d71265 (Wed Feb 19 12:47:40 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 19, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

pom.xml Show resolved Hide resolved
@zentol
Copy link
Contributor Author

zentol commented Mar 4, 2020

@StephanEwen What's your overall take on the PR?

@StephanEwen
Copy link
Contributor

Looks good to me, +1 to go ahead

@zentol zentol merged commit a762e76 into apache:master Mar 5, 2020
@zentol zentol deleted the 16172 branch March 17, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants