Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16163][build] Migrate to flink-shaded-zookeeper #11143

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Feb 19, 2020

Based on #11131.

With this PR the project now uses the zookeeper 3.4 version provided by flink-shaded. This dependency also bundles curator 4, rendering flink-shaded-curator obsolete and implicitly addressing FLINK-14177.

The vast majority of changes in this PR are imports.
The only notable .java file is ZooKeeperLeaderElectionTest, which adjusts some mocking behavior. With curator 4 the mocking resulted in errors, but I admittedly have not looked into it too much.

Beyond that, there is now a dependency management entry in the root pom for flink-shaded-zookeeper, the flink-runtime dependencies on zk/curator were replaced with the flink-shaded dependency. flink-runtime no longer bundles zookeeper; this responsibility is now deferred to flink-dist.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit cc722b6 (Wed Feb 19 13:58:36 UTC 2020)

Warnings:

  • 3 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 19, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann tillrohrmann self-assigned this Feb 20, 2020
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replacing ZooKeeper with our shaded ZooKeeper @zentol. LGTM. +1 for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants