Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16089][docs] Translate "Data Type" page of "Table API & SQL" into Chinese #11190

Closed
wants to merge 3 commits into from

Conversation

gauss1314
Copy link
Contributor

What is the purpose of the change

This pull request translates "Data Type" page of "Table API & SQL" into Chinese.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…hinese

Signed-off-by: gauss <gauss1314@gmail.com>
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit bd23794 (Sun Feb 23 05:25:09 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 23, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@wuchong
Copy link
Member

wuchong commented Feb 23, 2020

Hi @danny0405 , could you help to review this?

@danny0405
Copy link
Contributor

@wuchong , sure, let me take the review work.

docs/dev/table/types.zh.md Outdated Show resolved Hide resolved
docs/dev/table/types.zh.md Outdated Show resolved Hide resolved
docs/dev/table/types.zh.md Show resolved Hide resolved
docs/dev/table/types.zh.md Outdated Show resolved Hide resolved
docs/dev/table/types.zh.md Show resolved Hide resolved
docs/dev/table/types.zh.md Show resolved Hide resolved
docs/dev/table/types.zh.md Show resolved Hide resolved
docs/dev/table/types.zh.md Outdated Show resolved Hide resolved
docs/dev/table/types.zh.md Outdated Show resolved Hide resolved
Signed-off-by: gauss <gauss1314@gmail.com>
Signed-off-by: gauss <gauss1314@gmail.com>
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @gauss1314 and thanks for the reviewing @danny0405 .

Will slightly modify it and merge it.

an actual JVM class. In the past, it was difficult to map SQL standard types to this
abstraction. Furthermore, some types were not SQL-compliant and introduced without a
bigger picture in mind.
然而,`TypeInformation` 并不是被设计为表示独立于 JVM class 的逻辑类型。之前很难将 SQL 的标准类型映射到 `TypeInformation` 抽象。此外,有一些类型并不是兼容 SQL 的并且在没有更好的规划的时候被引进。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
然而,`TypeInformation` 并不是被设计为表示独立于 JVM class 的逻辑类型。之前很难将 SQL 的标准类型映射到 `TypeInformation` 抽象。此外,有一些类型并不是兼容 SQL 的并且在没有更好的规划的时候被引进
然而,`TypeInformation` 并不是为独立于 JVM class 的逻辑类型而设计的。之前很难将 SQL 的标准类型映射到 `TypeInformation` 抽象。此外,有一些类型并不是兼容 SQL 的并且引入的时候没有长远规划过


Starting with Flink 1.9, the Table & SQL API will receive a new type system that serves as a long-term
solution for API stability and standard compliance.
从 Flink 1.9 开始,Table & SQL API 将接收一种新的类型系统作为长期解决方案,用来保持 API 稳定性和 SQL 标准的兼容性。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
从 Flink 1.9 开始,Table & SQL API 将接收一种新的类型系统作为长期解决方案,用来保持 API 稳定性和 SQL 标准的兼容性。
从 Flink 1.9 开始,Table & SQL API 开始启用一种新的类型系统作为长期解决方案,用来保持 API 稳定性和 SQL 标准的兼容性。


Flink's data types are similar to the SQL standard's *data type* terminology but also contain information
about the nullability of a value for efficient handling of scalar expressions.
Flink 的数据类型和 SQL 标准的 *数据类型* 术语类似,但也包含了 nullability 信息,可以被用于 scala expression 的优化。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Flink 的数据类型和 SQL 标准的 *数据类型* 术语类似,但也包含了 nullability 信息,可以被用于 scala expression 的优化。
Flink 的数据类型和 SQL 标准的 *数据类型* 术语类似,但也包含了可空属性,可以被用于标量表达式(scalar expression的优化。

@wuchong wuchong closed this in 5781c67 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants