Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+ #11206

Merged
merged 1 commit into from Feb 25, 2020

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Feb 25, 2020

What is the purpose of the change

This pull request sets io.netty.tryReflectionSetAccessible to true for JDK9+. See https://issues.apache.org/jira/browse/ARROW-5412 for more details.

Brief change log

  • Adds -Dio.netty.tryReflectionSetAccessible=true option to the flink-python unit tests

Verifying this change

Tests manually in my local environment.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 127112a (Tue Feb 25 06:08:56 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 25, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianfu Thanks a lot for the quick fix. Looks good to me.
BTW, we may need to add a document for users to add this option when running on the JDK9+ environment. We can create another jira for this. What do you think?

@dianfu
Copy link
Contributor Author

dianfu commented Feb 25, 2020

@hequn8128 Thanks for the review and suggestion. I'm in favor of making it transparent for users, for example, setting this environment variable in the open method of the Arrow operator to be introduced. I will check if this is possible in the Arrow operator PR. If not, we can add a documentation for users.

@hequn8128
Copy link
Contributor

hequn8128 commented Feb 25, 2020

@dianfu Solve this automatically is good. FYI, (ARROW-7223), It seems setting the property won't help, as it's read at static initialization time. I have created a jira(FLINK-16273) for addressing this problem for users.

I will merge this once Travis passed.

@dianfu
Copy link
Contributor Author

dianfu commented Feb 25, 2020

@hequn8128 Thanks for creating the following-up ticket.

@hequn8128 hequn8128 merged commit 93da5ec into apache:master Feb 25, 2020
@dianfu dianfu deleted the FLINK-16263 branch June 10, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants