New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+ #11206
Conversation
…to true for JDK9+
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 127112a (Tue Feb 25 06:08:56 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianfu Thanks a lot for the quick fix. Looks good to me.
BTW, we may need to add a document for users to add this option when running on the JDK9+ environment. We can create another jira for this. What do you think?
@hequn8128 Thanks for the review and suggestion. I'm in favor of making it transparent for users, for example, setting this environment variable in the open method of the Arrow operator to be introduced. I will check if this is possible in the Arrow operator PR. If not, we can add a documentation for users. |
@dianfu Solve this automatically is good. FYI, (ARROW-7223), It seems setting the property won't help, as it's read at static initialization time. I have created a jira(FLINK-16273) for addressing this problem for users. I will merge this once Travis passed. |
@hequn8128 Thanks for creating the following-up ticket. |
What is the purpose of the change
This pull request sets io.netty.tryReflectionSetAccessible to true for JDK9+. See https://issues.apache.org/jira/browse/ARROW-5412 for more details.
Brief change log
-Dio.netty.tryReflectionSetAccessible=true
option to the flink-python unit testsVerifying this change
Tests manually in my local environment.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation