[FLINK-16281][Table SQL / Ecosystem] parameter 'maxRetryTimes' can not work in JDBCUpsertTableSink.

[leonardBang]

parameter 'maxRetryTimes' can not work in JDBCUpsertTableSink.

What is the purpose of the change

This pull request fix 'maxRetryTimes' can not work properly in JDBCUpsertTableSink( only AppendOnlyWriter) .

Brief change log

• Cache data in AppendOnlyWriter for multiple call
• Update executeBatch() in AppendOnlyWriter

Verifying this change

Test exception will be thrown normally in JDBCUpsertTableSinkITCase.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): ( no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 64692a3 (Wed Feb 26 13:43:12 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 46b6075 UNKNOWN
• 70e3c71 UNKNOWN
• 16f8eb6 Travis: SUCCESS Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[libenchao]

@leonardBang Thanks for your contribution. The pr generally looks good to me, I only left some minor comments.

[libenchao]

LGTM, +1 for merging.

[JingsongLi]

Thanks @leonardBang , left some comments.

[JingsongLi]

Thanks for updating, left some minor comments.

[JingsongLi]

Thanks for updating, +1.
Merging...

[JingsongLi]

I'll update title to [FLINK-16281][jdbc] Parameter 'maxRetryTimes' can not work in AppendOnlyWriter. FYI