Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-16417][e2e] Slightly increase offheap memory for ConnectedComp… #11315

Merged
merged 1 commit into from Mar 5, 2020
Merged

[FLINK-16417][e2e] Slightly increase offheap memory for ConnectedComp… #11315

merged 1 commit into from Mar 5, 2020

Conversation

rmetzger
Copy link
Contributor

@rmetzger rmetzger commented Mar 5, 2020 •
edited

What is the purpose of the change

The connected components tests was failing due to an off heap out of memory on JDK11. This PR increases the memory setting

See JIRA ticket for details: https://issues.apache.org/jira/browse/FLINK-16417

@rmetzger
[FLINK-16417][e2e] Slightly increase offheap memory for ConnectedComp…
ccadeae 
…onents test

The calculated off-heap size was 130 MB.
The test passes on JDK 11 when setting it to 270 MB.
The test fails on JDK 11 when setting it to 135 MB.
The test passes on JDK 11 when setting it to 160 MB.

This commit sets the memory to 160MB.
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 5, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ccadeae (Thu Mar 05 08:48:49 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 5, 2020 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@StephanEwen
Copy link
Contributor

+1

This is only needed as a temporary fix until FLINK-10742 is in. So it is important that this setting is only in the local config for that test, not in the config for all tests.

@rmetzger
Copy link
Contributor Author

rmetzger commented Mar 5, 2020

Thank you for your review!

Merging

@rmetzger rmetzger merged commit 2b19918 into apache:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=API/DataSet component=Tests review=description?
Projects
None yet
Milestone
No milestone
3 participants
@rmetzger @flinkbot @StephanEwen