[FLINK-2637] [api-breaking] [scala, types] Adds equals and hashCode method to TypeInformations and TypeSerializers #1134
Conversation
|
Big change, but I didn't spot anything suspicious. |
| /** | ||
| * Type information for numeric primitive types (int, long, double, byte, ...). | ||
| * Type information for numeric primitive types: int, long, double, byte, short, float, char, | ||
| * boolean. |
There was a problem hiding this comment.
Good catch. Will remove it.
|
Very good refactoring! I had just a few inline comments. |
tillrohrmann
force-pushed
the
fixOptionTypeInfo
branch
from
35a18b3
to
76eadec
Compare
tillrohrmann
force-pushed
the
fixOptionTypeInfo
branch
from
76eadec
to
25a59f4
Compare
|
Thanks for the fast update, LGTM. |
tillrohrmann
force-pushed
the
fixOptionTypeInfo
branch
from
25a59f4
to
cb6a126
Compare
| Long.class, | ||
| Byte.class, | ||
| Short.class, | ||
| Boolean.class, |
There was a problem hiding this comment.
Nope, I missed that. Will remove it.
…o TypeInformations and TypeSerializers - Fixes ObjectArrayTypeInfo - Makes CompositeTypes serializable - Adds test for equality relation's symmetric property - Adds test for PojoTypeInfo serializability This closes apache#1134
…ethod to TypeInformations and TypeSerializers. Fixes ObjectArrayTypeInfo. Makes CompositeTypes serializable. Adds test for equality relation's symmetric property Added test for PojoTypeInfo serializability
tillrohrmann
force-pushed
the
fixOptionTypeInfo
branch
from
cb6a126
to
5919cd7
Compare
…o TypeInformations and TypeSerializers - Fixes ObjectArrayTypeInfo - Makes CompositeTypes serializable - Adds test for equality relation's symmetric property - Adds test for PojoTypeInfo serializability This closes apache#1134
|
I understand you took the bot from Spark, but can you change the JIRA link? It is spamming the Spark JIRA right now. https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mxm |
|
Hey @rxin, I'm really sorry that this happened. Max told me that he stopped the application on AppEngine as soon as he learned that the tool is not working as expected. |
|
Hi @rxin, I'm really sorry for bothering. I was trying out the Spark Pull Request Dashboard with all the settings adapted to the Flink JIRA and Flink Github repository. Only when it was too late, I saw that there were some hard-coded URLs in the the source code that also needed to be adapted. This caused some unexpected behavior (Flink issue number in Flink pull requests being associated with Spark issues numbers). I've removed all comments and links and apologize very much for the inconvenience this caused. I've definitely learned a lesson out of this one. Thanks for your patience and understanding! |
…o TypeInformations and TypeSerializers - Fixes ObjectArrayTypeInfo - Makes CompositeTypes serializable - Adds test for equality relation's symmetric property - Adds test for PojoTypeInfo serializability This closes apache#1134
…o TypeInformations and TypeSerializers - Fixes ObjectArrayTypeInfo - Makes CompositeTypes serializable - Adds test for equality relation's symmetric property - Adds test for PojoTypeInfo serializability This closes apache#1134
Adds abstract
equals,hashCode,canEqualandtoStringmethods toTypeInformation. Adds missing implementations to subtypes. ThecanEqual(Object obj)method returns true iff theobjcan be equaled with the called instance.Adds abstract
equals,hashCodeandcanEqualmethods toTypeSerializer.Makes
CompositeTypesubtypes serializable by removing non-serializable fields which were only used for the comparator construction. The comparator construction is now realized within a builder object which keeps the intermediate state. Consequently, the PR #943 is now obsolete and can be closed.Refactors the
ObjectArrayTypeInfoso that the type extraction logic now happens within theTypeExtractorand no longer in theTypeInformationsubtype.