Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-2689] [runtime] Fix reuse of null object for solution set Joins and CoGroups #1136

Closed
wants to merge 1 commit into from

Conversation

fhueske
Copy link
Contributor

@fhueske fhueske commented Sep 16, 2015

Reuse object can become null if not match is found in the hash table. The next look-up will happen with a null-valued reuse object and fail.

This patch takes care that the reuse object does not become null.

@mxm
Copy link
Contributor

mxm commented Sep 17, 2015

LGTM

@fhueske
Copy link
Contributor Author

fhueske commented Sep 17, 2015

Thanks for the review.
Will merge this.

fhueske added a commit to fhueske/flink that referenced this pull request Sep 17, 2015
fhueske added a commit to fhueske/flink that referenced this pull request Sep 17, 2015
fhueske added a commit to fhueske/flink that referenced this pull request Sep 17, 2015
@asfgit asfgit closed this in 988a04e Sep 17, 2015
@srowen
Copy link
Member

srowen commented Sep 17, 2015

@fhueske not sure where else to mention this, but for some reason, PRs like this are causing Apache JIRA to comment on Spark JIRAs (see https://issues.apache.org/jira/browse/SPARK-2689 for instance). Is it maybe because the merge script or other setup from Spark is also used in Flink? Maybe something wasn't changed. Not a huge deal but worth tracking down

@rmetzger
Copy link
Contributor

Hi @srowen, thank you for notifying us. We were trying out https://github.com/databricks/spark-pr-dashboard on Google App Engine (because we are also getting more and more flooded by pull requests ;) ). It seems that we didn't properly configure and test the tool before starting it.
After you told us about the issue, we immediately stopped the tool. You can also see from Max (@mxm)'s JIRA activity (https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mxm) that he stopped changing Spark JIRAs three hours ago.
I'm really sorry that this has happened.
We'll manually clean up the Spark JIRAs.

nikste pushed a commit to nikste/flink that referenced this pull request Sep 29, 2015
lofifnc pushed a commit to lofifnc/flink that referenced this pull request Oct 8, 2015
@fhueske fhueske deleted the solutionSetJoinFix branch October 22, 2015 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants