Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16517][Examples] Add an embedded input to enable a long-running WordCount example #11432

Closed
wants to merge 1 commit into from

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Mar 18, 2020

What is the purpose of the change

This PR modifies the current WordCount example to have a SourceFunction that randomly generates input data based on a set of sentences, so the WordCount job can run forever. The generation interval is configurable.

This will be the easiest way to start a long running flink job and can be useful for new users to start using flink quickly, or for developers to test flink easily.

Brief change log

  • Added a new SourceFunction RandomSentenceSource that generates random data continuously until cancellation
  • Modified the WordCount example to use the RandomSentenceSource as the input optionally

Verifying this change

This change can be verified as follows:

  • Manually verified the change by running a 1 node cluster with 1 JobManagers and 1 TaskManagers, submitted the new WordCount jobs with --random option with different intervals and verified the jobs worked correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1df1ef1 (Wed Mar 18 02:24:22 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @Ethanlm. I was wondering whether the WindowJoin example is good enough as an easy example which can run infinitely. If this is the case, then we can close this PR and the respective JIRA issue.

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Mar 23, 2020

WindowJoin looks good.

I still feel like we need to change WordCount example so it can be a more streaming example. But it's up to you to decide whether doing it or not.

Thanks for the review. @tillrohrmann

@zentol
Copy link
Contributor

zentol commented Jun 9, 2020

Closing as Won't fix.

@zentol zentol closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants