Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15953][web] fix restarting status in web #11433

Closed
wants to merge 1 commit into from

Conversation

vthinkxie
Copy link
Contributor

@vthinkxie vthinkxie commented Mar 18, 2020

What is the purpose of the change

fix https://issues.apache.org/jira/browse/FLINK-15953

Brief change log

support more metric display at once

Verifying this change

  • Submit a restarting job
  • Go to the dashboard
  • check if the restarting status correct

before:
FireShot Capture 579 - Apache Flink Web Dashboard - localhost

after:
FireShot Capture 578 - Apache Flink Web Dashboard - localhost

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 76199dc (Wed Mar 18 07:32:04 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@GJL GJL self-assigned this Mar 18, 2020
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@GJL GJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@@ -29,6 +29,7 @@ export const COLOR_MAP = {
RECONCILING: '#eb2f96',
IN_PROGRESS: '#faad14',
SCHEDULED: '#722ed1',
COMPLETED : '#1890ff'
COMPLETED: '#1890ff',
RESTARTING: '#13c2c2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you chose the color?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a design system here

@import "../../node_modules/ng-zorro-antd/style/themes/default";

and for ant design 3.x version, the color is cyan-6 from https://github.com/NG-ZORRO/ng-zorro-antd/blob/45e84e8b99cd3cedb6face42538ae4faaf6dacf5/components/style/color/colors.less#L31

GJL pushed a commit to GJL/flink that referenced this pull request Mar 18, 2020
@GJL GJL closed this in 64abbdd Mar 19, 2020
liuzhixing1006 pushed a commit to liuzhixing1006/flink that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants