New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15953][web] fix restarting status in web #11433
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 76199dc (Wed Mar 18 07:32:04 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging.
@@ -29,6 +29,7 @@ export const COLOR_MAP = { | |||
RECONCILING: '#eb2f96', | |||
IN_PROGRESS: '#faad14', | |||
SCHEDULED: '#722ed1', | |||
COMPLETED : '#1890ff' | |||
COMPLETED: '#1890ff', | |||
RESTARTING: '#13c2c2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you chose the color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a design system here
@import "../../node_modules/ng-zorro-antd/style/themes/default"; |
and for ant design 3.x version, the color is cyan-6 from https://github.com/NG-ZORRO/ng-zorro-antd/blob/45e84e8b99cd3cedb6face42538ae4faaf6dacf5/components/style/color/colors.less#L31
What is the purpose of the change
fix https://issues.apache.org/jira/browse/FLINK-15953
Brief change log
support more metric display at once
Verifying this change
before:
after:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation