New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15771][FLINK-16583][tests] Fix issues around SQLClientKafkaITCase #11438
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 931d3a2 (Wed Mar 18 11:50:30 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twalthr , looks good to me.
Thanks will merge this and backport it to 1.10 if necessary. |
@wuchong correct me if I'm wrong, but I don't think this fix is necessary for 1.10. The test has been merged for 1.11 and the |
I think so. |
Fixes a classloading bug that was introduced in the last release while updating the code for the new Pipeline abstractions. This closes apache#11438.
What is the purpose of the change
This fixes a couple of issues related to the SQL Client and the SQLClientKafkaITCase.
In particular, it fixes a classloading bug that was introduced in the last release while updating the code for the new
Pipeline
abstractions,Brief change log
See commit messages.
Verifying this change
This change is already covered by existing tests, such as
SQLClientKafkaITCase
.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation