Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15771][FLINK-16583][tests] Fix issues around SQLClientKafkaITCase #11438

Closed
wants to merge 3 commits into from

Conversation

twalthr
Copy link
Contributor

@twalthr twalthr commented Mar 18, 2020

What is the purpose of the change

This fixes a couple of issues related to the SQL Client and the SQLClientKafkaITCase.

In particular, it fixes a classloading bug that was introduced in the last release while updating the code for the new Pipeline abstractions,

Brief change log

See commit messages.

Verifying this change

This change is already covered by existing tests, such as SQLClientKafkaITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 931d3a2 (Wed Mar 18 11:50:30 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twalthr , looks good to me.

@twalthr
Copy link
Contributor Author

twalthr commented Mar 19, 2020

Thanks will merge this and backport it to 1.10 if necessary.

@twalthr twalthr closed this in 6aa4a3f Mar 19, 2020
@twalthr
Copy link
Contributor Author

twalthr commented Mar 19, 2020

@wuchong correct me if I'm wrong, but I don't think this fix is necessary for 1.10. The test has been merged for 1.11 and the createPipeline is implemented differently in 1.10.

@wuchong
Copy link
Member

wuchong commented Mar 19, 2020

I think so. SQLClientKafkaITCase is migrated from test_sql_client_kafka.sh bash script since 1.11. We didn't spot any failures of test_sql_client_kafka.sh in 1.10. We can fix that for 1.10 when we find such error in the future.

liuzhixing1006 pushed a commit to liuzhixing1006/flink that referenced this pull request Mar 19, 2020
Fixes a classloading bug that was introduced in the last release while
updating the code for the new Pipeline abstractions.

This closes apache#11438.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants