[FLINK-1520] [gelly] Create a Graph from CSV files #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .map(new MapFunction<Tuple2<K, K>, Tuple3<K, K, NullValue>>() { | ||
|
|
||
| public Tuple3<K, K, NullValue> map(Tuple2<K, K> edge) { | ||
| return new Tuple3<K, K, NullValue>(edge.f0, edge.f1, NullValue.getInstance()); |
There was a problem hiding this comment.
Shouldn't you have a forwarded fields annotation here?
|
Hi @vasia, As you said, I already reviewed this :P. I left a couple of comments inline. Please reverify the forwarded fields annotations. If you put them there for one mapper, add them for the others too. Apart from that, it's good to merge. |
|
Thanks @andralungu! I'll address your comments and merge later. |
…a new file for tests. Made appropriate changes in gelly_guide.md
…om CSV input, with and without vertex/edge values. Changes the examples and the tests accordingly.
nikste
pushed a commit
to nikste/flink
that referenced
this pull request
Sep 29, 2015
… the graph csv reader This squashes the following commits: [FLINK-1520] [gelly] add named types methods for reading a Graph from CSV input, with and without vertex/edge values. Change the examples and the tests accordingly. [FLINK-1520] [gelly] corrections in Javadocs; updated documentation This closes apache#1149
lofifnc
pushed a commit
to lofifnc/flink
that referenced
this pull request
Oct 8, 2015
… the graph csv reader This squashes the following commits: [FLINK-1520] [gelly] add named types methods for reading a Graph from CSV input, with and without vertex/edge values. Change the examples and the tests accordingly. [FLINK-1520] [gelly] corrections in Javadocs; updated documentation This closes apache#1149
cfmcgrady
pushed a commit
to cfmcgrady/flink
that referenced
this pull request
Oct 23, 2015
… the graph csv reader This squashes the following commits: [FLINK-1520] [gelly] add named types methods for reading a Graph from CSV input, with and without vertex/edge values. Change the examples and the tests accordingly. [FLINK-1520] [gelly] corrections in Javadocs; updated documentation This closes apache#1149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @shghatge's work in #847.
I addressed the remaining issues, rebased, and edited the docs.
@andralungu, you've already reviewed this, but if you could give it one more look, that'd be great :)
Thanks!