[FLINK-2479] Refactor runtime.operators.* tests #1160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is very nice, thanks for the initiative, @zentol Hope to be able to have a look over it, soon. Looks in principle correct, but cannot hurt to have another pair of eyes check for subtle mistakes... |
|
I will shortly add another commit that removes the remaining Record portions in the TestData class and refactors its usages. Originally i planned a separate PR for those, but it took a lot less time than expected. |
| @@ -725,7 +718,7 @@ public void join(IntPair rec1, Record rec2, Collector<Record> out) throws Except | |||
| } | |||
| } | |||
|
|
|||
| static final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Record> | |||
| static final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Tuple2<Integer, String>> | |||
There was a problem hiding this comment.
should be IntPairTuplePairComparator
|
Hi @zentol, thanks for this effort! |
zentol
force-pushed
the
2479_testdata_pr
branch
from
1e1de5f
to
beaecf4
Compare
|
I've renamed the classes and rebased the PR. |
|
Thanks for the update @zentol! |
cfmcgrady
pushed a commit
to cfmcgrady/flink
that referenced
this pull request
Oct 23, 2015
lofifnc
pushed a commit
to lofifnc/flink
that referenced
this pull request
Oct 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors most runtime.operators tests to use the TupleGenerator introduced in FLINK-2105.
The changes made can generally be summed up as replacing usages of Records with Tuple2<Integer, String> and adjusting serializers/comparators accordingly. I've added a few static helper methods to the TestData class to simplify comparator/serializer(factory) creation.
One oddball change is the introduction of a separate IntPairComparator whose hash() implementation uses the underlying IntComparators hash() method, to be in line with the TupleComparators implementation.