New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy #11614
Conversation
cc @aljoscha |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6b182c9 (Thu Apr 02 08:43:12 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Good fix! I will wait for Travis or Azure and then merge. |
@flinkbot run azure |
@flinkbot run travis |
@flinkbot run azure |
@flinkbot run travis |
Thanks for the fix! 🍵 |
@aljoscha thanks for the review and merging. |
What is the purpose of the change
Fix the wrong logic of
NullableSerializer#copy
,currently, the logic is such as below:
we forgot to skip paddings.length bytes when if the padding's length is not 0.
We can correct the logic such as below
Verifying this change
Harden the test of
NullalbeSerialierTest#testSerializedCopyAsSequence
by update the test data.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation