Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16973][tests] Add tooling for collecting jvm crash files #11638

Closed
wants to merge 6 commits into from

Conversation

rmetzger
Copy link
Contributor

@rmetzger rmetzger commented Apr 5, 2020

What is the purpose of the change

A lot of tests are failing because of crashed JVMs.
This PR will add some tooling to search the Flink directory for JVM crash files.

Verifying this change

This change has been tested here: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=7072&view=results
In this test, the "core" profile fails with an artificially induced JVM crash. A coredump + some debugging files are attached.
There was a previous discussion about this change. I tried the proposed approach as well, but files were not properly written into the specified directory.

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 5, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3bd9092 (Sun Apr 05 13:58:28 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 5, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@rmetzger
Copy link
Contributor Author

rmetzger commented Apr 6, 2020

I will look into the precommit test failures on Travis

Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we be able to access those crash files? Will there be printed some url to download? Or is there some existing solution for that?

@rmetzger
Copy link
Contributor Author

rmetzger commented Apr 6, 2020

The crash files are part of the archive that also contains the full logs.

On azure, we are abusing the "pipeline artifact" feature to make those archives available. For the example mentioned in the pull request description, you see that the logs-ci-core is 300MB, because it contains a coredump.

Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % test failures (if they are related)

@zentol
Copy link
Contributor

zentol commented Apr 7, 2020

I suppose my previous suggestion doesn't work since surefire itself is copying the dump to target/surefire-reports and it doesn't seem possible to direct it to another directory. (it should be possible based on the docs, but it doesn't seem to work 👿 )

This will have to suffice.

@rmetzger
Copy link
Contributor Author

rmetzger commented Apr 7, 2020

Thanks for the feedback. Merging now.

@rmetzger
Copy link
Contributor Author

rmetzger commented Apr 7, 2020

Merged in aad3f7d

@rmetzger rmetzger closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants