New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16973][tests] Add tooling for collecting jvm crash files #11638
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3bd9092 (Sun Apr 05 13:58:28 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
I will look into the precommit test failures on Travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we be able to access those crash files? Will there be printed some url to download? Or is there some existing solution for that?
The crash files are part of the archive that also contains the full logs. On azure, we are abusing the "pipeline artifact" feature to make those archives available. For the example mentioned in the pull request description, you see that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % test failures (if they are related)
I suppose my previous suggestion doesn't work since surefire itself is copying the dump to This will have to suffice. |
Thanks for the feedback. Merging now. |
Merged in aad3f7d |
What is the purpose of the change
A lot of tests are failing because of crashed JVMs.
This PR will add some tooling to search the Flink directory for JVM crash files.
Verifying this change
This change has been tested here: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=7072&view=results
In this test, the "core" profile fails with an artificially induced JVM crash. A coredump + some debugging files are attached.
There was a previous discussion about this change. I tried the proposed approach as well, but files were not properly written into the specified directory.