New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16951][parquet] Integrate parquet to file system connector #11653
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b47050e (Tue Apr 07 07:28:44 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JingsongLi 's contribution, generally LGTM, left two minor comments.
* - parquet.writer.version | ||
* ... | ||
*/ | ||
public static final String PARQUET_PROPERTIES = "format.parquet"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use PARQUET_PROPERTIES_KEY here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like FormatDescriptorValidator.FORMAT
, I will add comments to say this is for prefix.
Configuration conf, | ||
boolean utcTimestamp) { | ||
this.limit = limit; | ||
super.setFilePaths(paths); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call parent's function first in constructor?
What is the purpose of the change
Users can use file system connector with parquet format in table.
Brief change log
Verifying this change
ParquetFileSystemITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation