Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16101][docs-zh] Translate "Hive Functions" page of "Hive Integration" into Chinese #11664

Closed
wants to merge 11 commits into from

Conversation

zzh1985
Copy link

@zzh1985 zzh1985 commented Apr 8, 2020

What is the purpose of the change

Translate the Hive functions doc to Chinese

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (docs )

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 8, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 47d39a1 (Wed Apr 08 02:34:33 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 8, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zzh1985 zzh1985 changed the title [FLINK-16080][docs] 更新 Hive functions 中文文档 [FLINK-16080][docs] Translate "Hive Functions" page of "Hive Integration" into Chinese Apr 8, 2020
@zzh1985 zzh1985 changed the title [FLINK-16080][docs] Translate "Hive Functions" page of "Hive Integration" into Chinese [FLINK-16080][docs-zh] Translate "Hive Functions" page of "Hive Integration" into Chinese Apr 8, 2020
@wuchong
Copy link
Member

wuchong commented Apr 8, 2020

Wrong issue number? I think it should be FLINK-16101?

@wuchong
Copy link
Member

wuchong commented Apr 8, 2020

Btw, please request assignee before open a pull request.

@wuchong wuchong requested a review from JingsongLi April 8, 2020 03:19
@zzh1985 zzh1985 changed the title [FLINK-16080][docs-zh] Translate "Hive Functions" page of "Hive Integration" into Chinese [FLINK-16101][docs-zh] Translate "Hive Functions" page of "Hive Integration" into Chinese Apr 8, 2020
@zzh1985
Copy link
Author

zzh1985 commented Apr 8, 2020

Sorry for that,the title of the issue contains two issue number like this :
Flink / FLINK-16080 Translate "Table API & SQL" pages into Chinese / FLINK-16101
I got the wrong number.
https://issues.apache.org/jira/browse/FLINK-16101?src=confmacro

@zzh1985
Copy link
Author

zzh1985 commented Apr 8, 2020

Btw, please request assignee before open a pull request.

How to request assignee, Sorry I'm a newbie.

@zzh1985
Copy link
Author

zzh1985 commented Apr 8, 2020

Btw, please request assignee before open a pull request.

How to request assignee, Sorry I'm a newbie.

In the https://issues.apache.org/jira/browse/FLINK-16101 and https://github.com/apache/flink page, I can't find the assignee request entrance.

@wuchong
Copy link
Member

wuchong commented Apr 8, 2020

Hi @zzh1985, you can leave a comment under FLINK-16101 issue page.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzh1985 thanks for your contribution, I left some comments.
Could you please update the git message log to English, and you can aslo reach to the wiki for more information about the doc translation.


The `HiveModule` provides Hive built-in functions as Flink system (built-in) functions to Flink SQL and Table API users.
在Flink SQL Table API 中,可以通过系统内置的`HiveModule` 来使用 Hive 内置函数,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
在Flink SQL 和 Table API 中,可以通过系统内置的`HiveModule` 来使用 Hive 内置函数,
在 Flink SQL 和 Table API 中,可以通过系统内置的`HiveModule` 来使用 Hive 内置函数,


For detailed information, please refer to [HiveModule]({{ site.baseurl }}/dev/table/modules.html#hivemodule).
详细信息,请参考 [HiveModule]({{ site.baseurl }}/dev/table/modules.html#hivemodule)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
详细信息,请参考 [HiveModule]({{ site.baseurl }}/dev/table/modules.html#hivemodule)。
详细信息,请参考 [HiveModule]({{ site.baseurl }}/zh/dev/table/modules.html#hivemodule)。

@@ -58,34 +58,33 @@ modules:
</div>
</div>

* NOTE that some Hive built-in functions in older versions have [thread safety issues](https://issues.apache.org/jira/browse/HIVE-16183).
We recommend users patch their own Hive to fix them.
* 请注意在旧版本的部分 Hive 内置函数存在 [线程安全问题](https://issues.apache.org/jira/browse/HIVE-16183)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* 请注意在旧版本的部分 Hive 内置函数存在 [线程安全问题](https://issues.apache.org/jira/browse/HIVE-16183)
* 请注意旧版本的部分 Hive 内置函数存在 [线程安全问题](https://issues.apache.org/jira/browse/HIVE-16183)

@@ -184,8 +183,7 @@ myudtf

{% endhighlight %}


Then, users can use them in SQL as:
此时,用户如果想使用这些UDF,在 SQL 中就可以这样写:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
此时,用户如果想使用这些UDF,在 SQL 中就可以这样写:
此时,用户如果想使用这些 UDF,在 SQL 中就可以这样写:

20010079 and others added 4 commits April 9, 2020 16:45
Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzh1985 thanks for the contribution, I left some comments.
sorry for the late response. please ping me if I did not give any response in the future. in case I missed the notification.

@@ -91,7 +91,7 @@ managed keyed state 接口提供不同类型状态的访问接口,这些状态

所有类型的状态还有一个`clear()` 方法,清除当前 key 下的状态数据,也就是当前输入元素的 key。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 应该只涉及 "Hive Functions" 页面的改动,“state.zh.md" 的修改改回去吧

- include a jar that contains that function in Flink's classpath
- use Blink planner.
- 通过 Hive Metastore 将带有 UDF 的 HiveCatalog 设置为当前会话的 catalog 后端。
- 引入 Flink classpath 中带有 UDF 的 jar 包。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的意思是说”应该将包含这个函数的的 jar 包加到 Flink 的 classpath 中“吧,现在的意思有一些不对

@@ -172,7 +171,7 @@ public class TestHiveUDTF extends GenericUDTF {

{% endhighlight %}

This comment was marked as resolved.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzh1985 thanks for addressing my comments, left two more comments. please take another look

@@ -472,7 +472,7 @@ val counts: DataStream[(String, Int)] = stream

## 使用 Managed Operator State

用户可以通过实现 `CheckpointedFunction` 或 `ListCheckpointed<T extends Serializable>` 接口来使用 managed operator state。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把这个文档的修改 revert 回去吧,这个 PR 仅修改 hive function 的翻译,改完后可以 ping 我

@@ -58,39 +58,38 @@ modules:
</div>
</div>

* NOTE that some Hive built-in functions in older versions have [thread safety issues](https://issues.apache.org/jira/browse/HIVE-16183).
We recommend users patch their own Hive to fix them.
* 请注意旧版本的部分 Hive 内置函数存在 [线程安全问题](https://issues.apache.org/jira/browse/HIVE-16183)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* 请注意旧版本的部分 Hive 内置函数存在 [线程安全问题](https://issues.apache.org/jira/browse/HIVE-16183)
* 请注意旧版本的部分 Hive 内置函数存在[线程安全问题](https://issues.apache.org/jira/browse/HIVE-16183)

@zzh1985
Copy link
Author

zzh1985 commented Jun 8, 2020

@klion26 按您的意思修改了,你再帮忙再给看一下。新手犯了一些低级错误,请见谅

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzh1985 thanks for addressing my comments, LGTM now.
ping @wuchong @rmetzger

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong closed this in dee868d Jun 9, 2020
wuchong pushed a commit that referenced this pull request Jun 9, 2020
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants