-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17011][tests] Introduce Builder to AbstractStreamOperatorTestHarness for testing #11676
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a53cb59 (Fri May 28 07:07:21 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@azagrebin please take a look at this PR, and I have to admit it's quite labor work to introduce these builders to clean up code. |
…arness for testing
…arness for testing
…TestHarness for testing
f9a52c8
to
a53cb59
Compare
So far, these test classes Still can't use
and so on |
What is the purpose of the change
Introduce Builder to
AbstractStreamOperatorTestHarness
,OneInputStreamOperatorTestHarness
andKeyedOneInputStreamOperatorTestHarness
for testing. This would make settingTtlTimeProvider
toKeyedOneInputStreamOperatorTestHarness
possible which is necessary for FLINK-16949 and FLINK-16581.Brief change log
AbstractStreamOperatorTestHarness
for testingOneInputStreamOperatorTestHarness
for testingKeyedOneInputStreamOperatorTestHarness
for testingVerifying this change
This change is a refactor of all tests and already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation