New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17093][python][table-planner][table-planner-blink] Fix Python UDF to make it work with inputs from composite field #11717
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ec06c31 (Mon Apr 13 12:19:43 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianfu Thaks a lot for the PR. Some minor comments.
} else if (PythonUtil.containsNonPythonCall(node)) { | ||
return PythonUtil.isNonPythonCall(node); | ||
} else { | ||
return node instanceof RexFieldAccess; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some document about split RexFieldAccess from PythonCorrelate for the PythonCorrelateSplitRule
?
} | ||
return false; | ||
} | ||
|
||
private boolean containsFieldAccessInputs(RexNode node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this method, use RexUtil.containsFieldAccess()
directly.
@hequn8128 Thanks a lot for the comments. Make sense to me and have updated the PR. |
@flinkbot run travis |
@flinkbot run azure |
@flinkbot run travis |
@flinkbot run azure |
…UDF to make it work with inputs from composite field
The test failure of Azure is a known issue tracked in FLINK-16572 |
@dianfu Thanks a lot for the update. Merging... |
What is the purpose of the change
This pull request fix Python UDF to make it work with inputs from composite field
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation