New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts #11765
Conversation
…ke it avaible after restart
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 22eef4c (Thu Apr 16 05:26:07 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
@KurtYoung Thanks for the contribution. can this feature be tested in UT ? |
I'm not sure we have a good way to test the history of JLine reader, but I do test it in my local setup. |
@flinkbot run travis |
I think we can learn from https://github.com/oncewang/hive/blob/master/beeline/src/test/org/apache/hive/beeline/TestBeeLineHistory.java There are some tests based on |
Good point, I will try to write some. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM
Save the cli command history to a hidden file and make it available after sql cli restarts