Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts #11765

Closed
wants to merge 2 commits into from

Conversation

KurtYoung
Copy link
Contributor

Save the cli command history to a hidden file and make it available after sql cli restarts

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 22eef4c (Thu Apr 16 05:26:07 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 16, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@KurtYoung
Copy link
Contributor Author

@flinkbot run azure

@godfreyhe
Copy link
Contributor

@KurtYoung Thanks for the contribution. can this feature be tested in UT ?

@KurtYoung
Copy link
Contributor Author

I'm not sure we have a good way to test the history of JLine reader, but I do test it in my local setup.

@KurtYoung
Copy link
Contributor Author

@flinkbot run travis

@godfreyhe
Copy link
Contributor

godfreyhe commented Apr 17, 2020

I think we can learn from https://github.com/oncewang/hive/blob/master/beeline/src/test/org/apache/hive/beeline/TestBeeLineHistory.java

There are some tests based on Terminal in CliClientTest.

@KurtYoung
Copy link
Contributor Author

Good point, I will try to write some.

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM

@KurtYoung KurtYoung closed this in a20ed14 Apr 18, 2020
@KurtYoung KurtYoung deleted the history branch April 18, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants