Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-16766][python]Support create StreamTableEnvironment without pa… #11769

Merged
merged 3 commits into from
Apr 23, 2020
Merged

[FLINK-16766][python]Support create StreamTableEnvironment without pa… #11769

merged 3 commits into from
Apr 23, 2020

Conversation

SteNicholas
Copy link
Member

What is the purpose of the change

This pull request will create StreamTableEnvironment without passing StreamExecutionEnvironment parameter.

Brief change log

  • Modify StreamExecutionEnvironment parameter to optional, support create StreamTableEnvironment without passing StreamExecutionEnvironment parameter through method create of TableTableEnvironment.

Verifying this change

  • Modify test_create_table_environment_with_blink_planner method to add create StreamTableEnvironment without passing StreamExecutionEnvironment test case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 91e1179 (Thu Apr 16 08:03:40 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@hequn8128 hequn8128 self-assigned this Apr 16, 2020
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 16, 2020 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

hequn8128
hequn8128 requested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@hequn8128 hequn8128 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteNicholas Thanks a lot for the improvement and good job! Left some comments below.

Could you also take a look at the test failure of Travis?

flink-python/pyflink/table/table_environment.py Outdated
>>> environment_settings = EnvironmentSettings.new_instance().use_blink_planner() \\
... .build()
>>> table_env = StreamTableEnvironment.create(
... env, environment_settings=environment_settings)
# create with EnvironmentSettings.
>>> table_env = BatchTableEnvironment.create(environment_settings=environment_settings)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BatchTableEnvironment => StreamTableEnvironment

flink-python/pyflink/table/table_environment.py Outdated
"""
Creates a :class:`~pyflink.table.TableEnvironment` for a
Creates a :class:`~pyflink.table.StreamTableEnvironment` for a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to

Creates a :class:`~pyflink.table.StreamTableEnvironment`.

since we can also create the TableEnvironment without the execution environment.

flink-python/pyflink/table/table_environment.py Outdated
@@ -1280,7 +1297,8 @@ def connect(self, connector_descriptor):
@staticmethod
def create(execution_environment=None, table_config=None, environment_settings=None):
"""
Creates a :class:`~pyflink.table.BatchTableEnvironment`.
Creates a :class:`~pyflink.table.BatchTableEnvironment` for a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the change as we can also create the TableEnvironment without the execution_environment.

hequn8128
hequn8128 requested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteNicholas Thanks a lot for the update. Looks good except for the single comment below.

flink-python/pyflink/table/tests/test_table_environment_api.py
@@ -296,6 +296,15 @@ def test_create_table_environment_with_blink_planner(self):
planner.getClass().getName(),
"org.apache.flink.table.planner.delegation.StreamPlanner")

t_env = StreamTableEnvironment.create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we can also add tests for flink planner. FYI: test will be failed for flink planner with the current PR.

hequn8128
hequn8128 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteNicholas Thanks a lot for the updates. Will merge this once tests have passed.

@hequn8128 hequn8128 merged commit c694954 into apache:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hequn8128 hequn8128 hequn8128 approved these changes

Assignees

@hequn8128 hequn8128

Labels
component=API/Python review=description?
Projects
None yet
Milestone
No milestone
4 participants
@SteNicholas @flinkbot @hequn8128 @rmetzger