New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages #11915
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit dc1358b (Mon Apr 27 03:27:16 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@@ -94,7 +94,10 @@ make_python_release() { | |||
cd flink-python/ | |||
# use lint-python.sh script to create a python environment. | |||
dev/lint-python.sh -s basic | |||
set +eu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need this change?
@@ -109,14 +112,30 @@ make_python_release() { | |||
|
|||
cp ${pyflink_actual_name} "${RELEASE_DIR}/${pyflink_release_name}" | |||
|
|||
# RM need to move the downloaded wheel packages from Azure CI to the directory of flink-python/dist manually. | |||
for wheel_file in *.whl; do | |||
if [[ ! ${wheel_file} =~ ^apache_flink-$PYFLINK_VERSION- ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the name of the wheel package is apache_flink-version.whl
instead of apache-flink-version.whl
?
c64af9f
to
373433f
Compare
What is the purpose of the change
This pull request will Add the sign and sha logic for PyFlink wheel packages
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation