New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17374] Remove travis-related files #11921
Conversation
Note: one commit message is off |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 14cfe31 (Mon Apr 27 11:54:18 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to remove all travis reference in this PR, or are you content with just removing files?
tools/log4j-travis.properties could also be renamed |
@@ -25,7 +25,7 @@ if [ -z "$HERE" ] ; then | |||
exit 1 # fail | |||
fi | |||
|
|||
source "${HERE}/travis/stage.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why this is still called travis_watchdog.sh?
Reported unstable test from CI run: https://issues.apache.org/jira/browse/FLINK-17463 |
I don't know if it is a good idea or not, but I wanted to do a first quick PR to disable travis, and then do a bigger PR where I split things like There are so many mentions of "travis" throughout the code, that this would require a much bigger change, and I didn't want to obfuscate this PR too much. FLINK-17375 is for tracking the cleanup work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea too, was just wondering since you are also renaming that one directory.
But it appears we didn't break anything, so +1.
What is the purpose of the change
Disable build processing on travis-ci.
Brief change log
I will open one or more additional pull requests cleaning up the codebase as described in FLINK-17375.