[FLINK-17182][network] Fix the unstable input channel test by recycling exclusive and floating buffer in the same thread #11924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c9d0fc6 (Mon Apr 27 16:09:42 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
gaoyunhaii
force-pushed
the
formal_fix_input_channel_test
branch
from
c9d0fc6
to
e9ef0b9
Compare
zhijiangW
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Thanks for the fix @gaoyunhaii !
LGTM! Before merging we should resolve the conflicts now.
…ng exclusive and floating buffer in the same thread
gaoyunhaii
force-pushed
the
formal_fix_input_channel_test
branch
from
e9ef0b9
to
79d4c84
Compare
zhijiangW
pushed a commit
that referenced
this pull request
Jun 12, 2020
….testConcurrentOnSenderBacklogAndRecycle
In this unstable unit test, the exclusive buffers and floating buffers are recycled by different
threads, which might cause unexpected race condition issue. But actually they should always be
recycled by the same task thread in practice. So we refactor the test process to recycle them in
the same thread to avoid potential unnecessary issues.
This closes #11924.
zhangjun0x01
pushed a commit
to zhangjun0x01/flink
that referenced
this pull request
Jul 8, 2020
….testConcurrentOnSenderBacklogAndRecycle
In this unstable unit test, the exclusive buffers and floating buffers are recycled by different
threads, which might cause unexpected race condition issue. But actually they should always be
recycled by the same task thread in practice. So we refactor the test process to recycle them in
the same thread to avoid potential unnecessary issues.
This closes apache#11924.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes the unstable input channel test.
Currently some test might be unstable with specific thread concurrency when we simulating the cases that recycling exclusive and floating buffers in different threads. However, in realistic there should be no such cases. Therefore, we could change the recycling into the same thread.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation