New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17497][e2e] Properly switch to Scala 2.12 in quickstart test #12016
[FLINK-17497][e2e] Properly switch to Scala 2.12 in quickstart test #12016
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c197990 (Thu May 07 06:49:31 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sed grammar correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % one comment and assuming fix is working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the update @rmetzger :)
Thanks! Merged. |
What is the purpose of the change
The quickstart test was sometimes failing because the scala 2.11 quickstart was used in the scala 2.12 build.
Brief change log
Verifying this change
Validated in my personal CI: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=7952&view=results