-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17353][docs] Fix Broken links in Flink docs master #12196
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 19f5ffd (Fri Oct 16 10:49:56 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
cc @wuchong |
@@ -0,0 +1,132 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This md is added for matching English flink-architecture.md
@yangyichao-mango thanks for your contribution. could you please share the result after execute |
@klion26 That is the result of spider.log http://localhost:4000/ops/memory/mem_setup_jm.html But All of this three broken links don't belong to [FLINK-17353]. |
Hi @yangyichao-mango , please fix them too. This issue is aiming to fix all the broken links to make the CRON build pass. |
That is the result of check_links.sh. http://localhost:4000/zh/ops/memory/mem_detail.html When I try to fix http://localhost:4000/zh/ops/memory/mem_detail.html, I'm blocked by three mds that are not updated to match English md. ops/memory/mem_setup_tm.md I think we should create a new jira issue to update those mds. When that new issue is done, I can continue to fix this broken link (http://localhost:4000/zh/ops/memory/mem_detail.html). cc @wuchong |
Merged and created an following up issue FLINK-17807 to resolve this broken link. |
What is the purpose of the change
Fix all of the broken links in Flink docs master mentioned in [FLINK-17353]
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation