New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[FLINK-13827][script] shell variable should be escaped" #12213
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c30d3ec (Fri Oct 16 10:51:03 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @zentol. The change itself looks good to me. Quick question: Are we now supporting paths which contain whitespaces which FLINK-13872 tried to solve?
Probably not. I'll try adding some escaped quotes to the individual log settings. |
Sounds good @zentol. |
@tillrohrmann Escaped quotes don't; but I found another solution using arrays in the BashFAQ. There were also other cases where we did not properly handled spaces (FLINK-17809); I have included a fix for this in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this PR @zentol. LGTM. +1 for merging.
This reverts commit 865cc4c.
The addition of quotes means that the log settings are passed as a single argument, rendering it ineffective.