Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FLINK-13827][script] shell variable should be escaped" #12213

Merged
merged 2 commits into from May 19, 2020

Conversation

zentol
Copy link
Contributor

@zentol zentol commented May 18, 2020

This reverts commit 865cc4c.

The addition of quotes means that the log settings are passed as a single argument, rendering it ineffective.

@flinkbot
Copy link
Collaborator

flinkbot commented May 18, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c30d3ec (Fri Oct 16 10:51:03 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 18, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. The change itself looks good to me. Quick question: Are we now supporting paths which contain whitespaces which FLINK-13872 tried to solve?

@zentol
Copy link
Contributor Author

zentol commented May 18, 2020

Probably not. I'll try adding some escaped quotes to the individual log settings.

@tillrohrmann
Copy link
Contributor

Sounds good @zentol.

@zentol
Copy link
Contributor Author

zentol commented May 19, 2020

@tillrohrmann Escaped quotes don't; but I found another solution using arrays in the BashFAQ.
This seems to work.
... I also found this in flink-daemon.sh; could've saved some time there...

There were also other cases where we did not properly handled spaces (FLINK-17809); I have included a fix for this in this PR.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this PR @zentol. LGTM. +1 for merging.

@zentol zentol merged commit 2f18138 into apache:master May 19, 2020
@zentol zentol deleted the 17763 branch June 2, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants