[FLINK-17965][sql-parser-hive] Hive dialect needs to unescape backslash in string literals #12378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 54651d2 (Thu May 28 11:24:06 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
lirui-apache
force-pushed
the
FLINK-17965
branch
2 times, most recently
from
7730fcf
to
aa2b18f
Compare
danny0405
reviewed
Jun 5, 2020
| public static SqlTableOption unescapeTableOption(SqlTableOption option) { | ||
| String key = StringEscapeUtils.unescapeJava(option.getKeyString()); | ||
| String val = StringEscapeUtils.unescapeJava(option.getValueString()); | ||
| SqlNode keyNode = SqlLiteral.createCharString(key, option.getKey().getParserPosition()); |
There was a problem hiding this comment.
I think we only need to unescape the option value.
There was a problem hiding this comment.
Both key and value can have special characters in Hive.
...e/flink-sql-parser-hive/src/main/java/org/apache/flink/sql/parser/hive/ddl/HiveDDLUtils.java
Show resolved
Hide resolved
|
|
||
| public static void unescapePartitionSpec(SqlNodeList partSpec) { | ||
| if (partSpec != null) { | ||
| for (int i = 0; i < partSpec.size(); i++) { |
There was a problem hiding this comment.
I have changed to use SqlShuttle
JingsongLi
pushed a commit
that referenced
this pull request
Jun 11, 2020
…sh in string literals This closes #12378
nicusX
pushed a commit
to nicusX/flink
that referenced
this pull request
Jun 13, 2020
…sh in string literals This closes apache#12378
zhangjun0x01
pushed a commit
to zhangjun0x01/flink
that referenced
this pull request
Jul 8, 2020
…sh in string literals This closes apache#12378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
HiveQL supports escaping by backslash. But SQL CLI will escape backslashes in its input. Therefore hive dialect needs to unescape it.
Brief change log
Verifying this change
I have manually verified the test cases (except view tests due to FLINK-17113) in
HiveDialectTestvia SQL CLI. But cannot add new tests for them since we don't have E2E tests for hive connector.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation