New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18034][runtime] Introduce PreferredLocationsRetriever #12423
[FLINK-18034][runtime] Introduce PreferredLocationsRetriever #12423
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 362a648 (Mon Jun 01 08:31:50 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/PreferredLocationsRetriever.java
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java
Outdated
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java
Outdated
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java
Outdated
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/flink/runtime/scheduler/ExecutionVertexSchedulingRequirements.java
Show resolved
Hide resolved
...runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractExecutionSlotAllocator.java
Outdated
Show resolved
Hide resolved
...runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractExecutionSlotAllocator.java
Outdated
Show resolved
Hide resolved
7a2dfb6
to
979c16d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comment @zhuzhurk
I think we can merge this even independently from #12375 (FLINK-17017).
...src/test/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetrieverTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetrieverTest.java
Show resolved
Hide resolved
…Retriever to get preferred locations for tasks
…nVertexSchedulingRequirements
… used in production
979c16d
to
1a11a1c
Compare
@azagrebin yes you are right this PR is independent from #12375. |
Thanks a lot for the reviewing! @azagrebin |
What is the purpose of the change
Preferred locations based on state and inputs are scattered into multiple components, which makes it harder to reasoning the calculation and complicates those hosting components.
This PR is to introduce a PreferredLocationsRetriever to be used by ExecutionSlotAllocator which returns preferred locations of an execution vertex and hides the details of the calculation from other components.
This PR is based on #12256.
Brief change log
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation