Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18034][runtime] Introduce PreferredLocationsRetriever #12423

Merged

Conversation

zhuzhurk
Copy link
Contributor

@zhuzhurk zhuzhurk commented Jun 1, 2020

What is the purpose of the change

Preferred locations based on state and inputs are scattered into multiple components, which makes it harder to reasoning the calculation and complicates those hosting components.
This PR is to introduce a PreferredLocationsRetriever to be used by ExecutionSlotAllocator which returns preferred locations of an execution vertex and hides the details of the calculation from other components.
This PR is based on #12256.

Brief change log

  • Introduced PreferredLocationsRetriever
  • Change ExecutionSlotAllocator to use PreferredLocationsRetriever

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 1, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 362a648 (Mon Jun 01 08:31:50 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 1, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@azagrebin azagrebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zhuzhurk
It looks quite good to me, I have left some smaller comments.
Also, I believe, it would be simpler to merge this as a pre-step for #12256 and base other PRs on it
then we do not need to move the preferred location code again into AbstractExecutionSlotAllocator in #12256.

@zhuzhurk zhuzhurk force-pushed the FLINK_18034_PreferredLocationsRetriever branch 2 times, most recently from 7a2dfb6 to 979c16d Compare June 5, 2020 16:52
Copy link
Contributor

@azagrebin azagrebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comment @zhuzhurk
I think we can merge this even independently from #12375 (FLINK-17017).

@zhuzhurk zhuzhurk force-pushed the FLINK_18034_PreferredLocationsRetriever branch from 979c16d to 1a11a1c Compare June 10, 2020 10:26
@zhuzhurk
Copy link
Contributor Author

@azagrebin yes you are right this PR is independent from #12375.
I have rebased it onto the latest master.

@zhuzhurk
Copy link
Contributor Author

zhuzhurk commented Jun 11, 2020

Thanks a lot for the reviewing! @azagrebin
The failed test 'Run Kubernetes test' is due to the broken test env and not related to this PR.
Merging.

@zhuzhurk zhuzhurk merged commit 216f65f into apache:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants