Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-2844][jobmanager] remove old web interface #1246

Closed
wants to merge 2 commits into from

Conversation

mxm
Copy link
Contributor

@mxm mxm commented Oct 9, 2015

The new web interface supports all features of the old web interface once #1164 and #1233 have been merged. It's time to remove the old one.

@mxm
Copy link
Contributor Author

mxm commented Oct 9, 2015

The WebFrontendITCase still needs to be adapted.

@StephanEwen
Copy link
Contributor

This should also remove all Jetty dependencies (runtime pom and root pom)

@sachingoel0101
Copy link
Contributor

YarnSessionFIFOITCase checks the old job manager web interface. We should change that too.

@mxm
Copy link
Contributor Author

mxm commented Oct 15, 2015

An update from my side. I have

  • adapted the WebFrontendITCase
  • adapted the YarnSessionFIFOITCase
  • removed the Jetty dependencies

Based on #1222 I changed the serving of the static files to work with the fat jar and a temporary directory. This is the default way now and ensures that everything works standalone and on YARN.

@rmetzger
Copy link
Contributor

I suspect we can close #1222 then?

@mxm
Copy link
Contributor Author

mxm commented Oct 15, 2015

Yes, #1222 is obsolete now.

- make new web one the default
- adapt tests
- make web directory a resource to be included in the fat jar
- serve static files of web interface dynamic through the class loader
- run on YARN
- remove Jetty dependencies from poms
@mxm
Copy link
Contributor Author

mxm commented Oct 15, 2015

Build passes (ScalaShellLocalStartupITCase has some hickups).

@StephanEwen
Copy link
Contributor

Nice, will merge this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Oct 16, 2015
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Oct 16, 2015
@asfgit asfgit closed this in 4593109 Oct 17, 2015
s1ck pushed a commit to s1ck/flink that referenced this pull request Oct 20, 2015
cfmcgrady pushed a commit to cfmcgrady/flink that referenced this pull request Oct 23, 2015
lofifnc pushed a commit to lofifnc/flink that referenced this pull request Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants