[FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink

[JingsongLi]

What is the purpose of the change

The sink of different jobs (or the same SQL runs multiple times) will produce the same file name, the rename will fail, and different file systems will produce different results:

• HadoopFileSystem: ignore new data.
• LocalFileSystem: overwrite old data.

Brief change log

We can add UUID to prefix, make sure there is no conflict between jobs.

Verifying this change

• HiveTableSinkITCase.testBatchAppend
• HiveTableSinkITCase.testStreamingAppend
• FileSystemITCaseBase.testInsertAppend
• FileSystemITCaseBase.testInsertOverwrite

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7fe7332 (Thu Jun 04 13:07:13 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 8f5f676 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[JingsongLi]

CC: @gaoyunhaii @lirui-apache

[gaoyunhaii]

Hi @JingsongLi , I reviewed the usage of OutputFileConfig in FileSystemTableSink and HiveTableSink, and I think it is OK from my side.

[gaoyunhaii]

Here seems inconsistent with this method's comment: rename does not delete the dest path if it exists on HDFS. Instead, it will keep the srcPath and dest Path unchanged.

[JingsongLi]

The comment is out of date, the overwrite is occurred in overwrite(Path) method instead of here.
Now it is consistent with HadoopRecoverableFsDataOutputStream.commit.
I will update comments.

[JingsongLi]

Thanks @gaoyunhaii for review, merging...