Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-17422] Create user document for the external resource framewor… #12538

Closed
wants to merge 2 commits into from

Conversation

KarmaGYZ
Copy link
Contributor

@KarmaGYZ KarmaGYZ commented Jun 9, 2020

…k and the GPU plugin

What is the purpose of the change

Create user document for the external resource framework and the GPU plugin

Brief change log

Create user document for the external resource framework and the GPU plugin

Verifying this change

Manually build the user doc.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 9, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6676085 (Tue Jun 09 04:08:27 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 9, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @KarmaGYZ. I had few minor comments. Please ping me once you have them resolved. Once they are resolved, I will merge this PR.

docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved

# Existing supported external resource plugins

Currently, Flink supports GPUs as external resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved
docs/ops/external_resources.md Outdated Show resolved Hide resolved
@KarmaGYZ
Copy link
Contributor Author

Thanks for the review @tillrohrmann ! I've updated the PR.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments @KarmaGYZ. LGTM. Merging this PR now.

tillrohrmann pushed a commit that referenced this pull request Jun 11, 2020
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
@KarmaGYZ KarmaGYZ deleted the FLINK-17422 branch May 13, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants