[FLINK-18232][hive] Fix Hive streaming source bugs

[JingsongLi]

What is the purpose of the change

• Hive streaming source HiveMapredSplitReader reuse row in a wrong way, if change reuse row instance, will loose partition fields.
• When converting Flink File split to Hadoop File split, length should not be -1.
• DirectoryMonitorDiscovery should convert DFS modificationTime to UTC time mills.
• HiveTableSource.createStreamSourceForNonPartitionTable should use local zone mills instead of UTC mills because ContinuousFileMonitoringFunction use local zone mills.

Verifying this change

• HiveTableSourceITCase.testStreamPartitionRead
• HiveTableFileInputFormatTest
• DirectoryMonitorDiscoveryTest
• Manually testing.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: (no
• The runtime per-record code paths (performance sensitive): (no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no
• The S3 file system connector: (no

Documentation

• Does this pull request introduce a new feature? (no

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit afc18c9 (Wed Jun 10 07:34:42 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• a6ef062 Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[lirui-apache]

Can we update the doc of FileInputSplit::getLength() to indicate length == -1 means to read all data from the file? I'll feel more comfortable about this change if it's guaranteed by the API contract.

[JingsongLi]

Actually, there are comments in FileInputSplit: the number of bytes in the file to process (-1 is flag for "read whole file")

[lirui-apache]

Add some comments for this method? What is a suitable partition?

[lirui-apache]

LGTM except for one minor comment