New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18315][table-planner-blink] Insert into partitioned table can … #12677
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit e7234f4 (Tue Jun 16 09:00:49 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…fail with values The VALUES would be patched up with partition fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 to merge when build is passed.
…with VALUES doesn't work correctly The VALUES would be patched up with partition fields. This closes apache#12677
…fail with values
What is the purpose of the change
Before this patch,
insert into partiton ... values
could not work correctly.Brief change log
Verifying this change
Added ITCases.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation