Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18423][docs] Fix Prefer tag in document "Detecting Patterns" age of "Streaming Concepts" #12764

Merged
merged 1 commit into from Jun 28, 2020

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

Update Prefer tag in documentation "Detecting Patterns" page of "Streaming Concepts" according to Prefer Reminder .The markdown file location is:  flink/docs/dev/table/streaming/match_recognize.md

Brief change log

update Prefer tag

  • Prefer tags like ({% site.baseurl %}/A/B.html) have been written as the pattern ({% link A/B.md %}) in flink/docs/dev/table/streaming/match_recognize.md

Verifying this change

Only document updates have been made in docs/dev/table/streaming/match_recognize.md

This change is a document update without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f9febcc (Wed Jun 24 09:03:37 UTC 2020)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 24, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@RocMarshal
Copy link
Contributor Author

Hi, @wuchong
I have updated 'Prefer tag' in documentation "Detecting Patterns" page of "Streaming Concepts" according to Prefer Reminder.The markdown file location is: flink/docs/dev/table/streaming/match_recognize.md

When I translate this page into Chinese, I will update the reference links accordingly(https://issues.apache.org/jira/browse/FLINK-16087).

And could you help me to review this PR(#12764)?
Thank you.

Best,
Roc.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RocMarshal . LGTM.

@wuchong wuchong merged commit a5c2f26 into apache:master Jun 28, 2020
wuchong pushed a commit that referenced this pull request Jun 28, 2020
@RocMarshal RocMarshal deleted the FLINK-18423 branch June 28, 2020 09:03
fsk119 pushed a commit to fsk119/flink that referenced this pull request Jul 6, 2020
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants