New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18163][task] Add RecordWriter.volatileFlusherException #12827
[FLINK-18163][task] Add RecordWriter.volatileFlusherException #12827
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a47aa12 (Mon Jul 06 08:56:33 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
CI build failure unrelated: https://issues.apache.org/jira/browse/FLINK-18485 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % one suggestion (adding a comment). Is the test failure related?
No,
(2nd build is PENDING at the moment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you squash the commits so I could merge it?
0f39d59
to
43390e7
Compare
Done. |
What is the purpose of the change
RecordWriter.flusherException
is updated by one thread and checked by another.The field is deliberately non-volatile for performance reasons.
But this way exception can be never seen by the 2nd thread.
This PR adds an additional volatile field which is checked every N times.
Verifying this change
TBD: no tests added yet
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation