New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18638][runtime] FutureUtils support timeout message #12932
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit cdf442e (Sun Jul 19 09:27:54 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@StephanEwen @GJL @wuchong please take a look, if you have time, thanks |
cdf442e
to
f53c211
Compare
@zhijiangW @tillrohrmann please take a look, if you have time, thanks |
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
Outdated
Show resolved
Hide resolved
@zentol thanks for your review! I has fix it. |
What is the purpose of the change
FutureUtils#orTimeout maybe throw a TimeoutException without timeout message,
This is rather vague and not friendly enough to analyze the problem.
so i think maybe throw a TimeoutException with a timeout message is better.
Brief change log
add timeout message for FutureUtils#orTimeout
Verifying this change
no
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation