[FLINK-1982] [record-api] Remove dependencies on Record API from flink-runtime tests #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-runtime tests Rename Match*Test to Join*Test
| @@ -39,7 +38,7 @@ | |||
| import org.junit.Test; | |||
|
|
|||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
this suppression can be removed
There was a problem hiding this comment.
Good catch, thanks!
Will check the other classes as well.
|
Updated |
| @@ -38,8 +37,7 @@ | |||
| import org.junit.Assert; | |||
| import org.junit.Test; | |||
|
|
|||
| @SuppressWarnings("deprecation") | |||
| public class MapTaskTest extends DriverTestBase<GenericCollectorMap<Record, Record>> { | |||
| public class MapTaskTest extends DriverTestBase<FlatMapFunction<Record, Record>> { | |||
There was a problem hiding this comment.
Small nit: should probably rename this to FlatMapTaskTest since now it is actually using flatMap function instead?
fhueske
force-pushed
the
runtimeTestsRecord
branch
from
36d8fa4
to
9df82a9
Compare
|
Thanks @hsaputra |
|
Will merge this PR |
asfgit
pushed a commit
that referenced
this pull request
Oct 23, 2015
…k-runtime tests Rename Match*Test to Join*Test and MapTaskTest to FlatMapTaskTest This closes #1294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Match_Test to Join_Test