New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18656][network,metrics] Fix startDelay metric for unaligned checkpoints #12989
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 77a6fb4 (Fri Jul 24 14:49:28 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is correct but not enough: when registering a metric, AlternatingCheckpointBarrierHandler
is used, not CheckpointBarrierUnaligner
.
So we also need to override AlternatingCheckpointBarrierHandler.getCheckpointStartDelayNanos
to delegate to activeHandler
.
4174e80
to
abec5ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch @rkhachatryan . Can you take a look at the fixup commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pnowojski.
LGTM.
…eckpoints Before this fix, startDelay metric was always set to zero for unaligned checkpoints.
Before this fix,
startDelay
metric was always set to zero for unaligned checkpoints.Verifying this change
This change adds a unit test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation