New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18777][catalog] Supports schema registry catalog #13033
Conversation
@@ -33,7 +33,7 @@ under the License. | |||
|
|||
<properties> | |||
<kafka.version>2.4.1</kafka.version> | |||
<confluent.version>5.4.2</confluent.version> | |||
<confluent.version>5.5.1</confluent.version> | |||
</properties> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade to new version client so that we can fetch for format type from the SchemaMetadata
.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b73c589 (Fri Jul 31 05:05:35 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
b73c589
to
f40e573
Compare
f40e573
to
18f6f1b
Compare
@danny0405 |
@danny0405 I'll try to test this PR. |
I'd say it won't make it in 1.12. I talked with @knaufk some time ago that we should probably conclude the FLIP that was started around it first before proceeding with the contribution. |
@dawidwys |
Yes, that is possible. |
@danny0405
|
@maver1ck When i write the code, the FLIP-107 was not started yet, i would fix the compile issue. |
@dawidwys
|
@maver1ck I'll look into it. What is the motivation for upgrading the version? Can't you simply upgrade the version in your job? |
Motivation: to have possibility to run this code on ververica platform when version 1.12 will be available. I can add dependency in my job. |
What is the purpose of the change
Supports a catalog that can read the kafka topics flexibly.
The demo code:
Brief change log
SchemaRegistryCatalog
Verifying this change
Added UTs.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation