[FLINK-2939][web-dashboard] Add support to cancel jobs from the dashboard #1313
Conversation
|
Thanks! Not sure users will see the "X" in the corner and understand it's for cancelling jobs. |
|
Hovering over the cross reveals the word cancel. |
|
This goes a bit against the idea of REST. If you "GET" a certain URL, it should not affect the state of the system you query. If we want to make that action part of the REST API, we should probably add a "DELETE" action for the URL "jobs/". |
sachingoel0101
force-pushed
the
cancel_button
branch
from
7726877
to
2f909dc
Compare
|
@StephanEwen that's a good point. I've already pushed a fix. :) |
Could we also have a button labelled "Cancel Job"? That way people don't even have to hover over things to get the meaning... |
|
I would like to merge this soon. Cancellation jobs from the web frontend has been requested several times. |
|
Thank you for noticing that @mxm. Will push a commit to address all your comments in a little while. |
sachingoel0101
force-pushed
the
cancel_button
branch
from
2f909dc
to
e3f6785
Compare
|
Here are the new screenshots: @mxm Can you look this over again? |
sachingoel0101
force-pushed
the
cancel_button
branch
from
e3f6785
to
b268e69
Compare
| @@ -70,6 +70,10 @@ angular.module('flinkApp') | |||
|
|
|||
| $interval.cancel(refresher) | |||
|
|
|||
| $scope.cancelJob = (cancelEvent) -> | |||
| angular.element(cancelEvent.currentTarget).removeClass('label-danger').addClass('label-info').html('Cancelling...') | |||
There was a problem hiding this comment.
Why do you have to remove the 'label-danger' class?
There was a problem hiding this comment.
I wanted the button to have an info color while the job is being cancelled.
|
Sure. No problem. :) |
|
Much better. Is there a way of making this thing look more like a button? Right now it looks very much like a label and I would not think of trying to click it... |
|
@StephanEwen , since this is already merged, I'll push another commit and point you to it for merging. |
|
@StephanEwen Sorry, didn't see your post. I filed a follow-up JIRA for this: https://issues.apache.org/jira/browse/FLINK-2957 |
Cancel button placement (open for discussion and/or any changes):
After cancelling:
Also includes some documentation fixes for the web frontend project to reflect the recent changes.