[FLINK-18999][table-planner-blink][hive] Temporary generic table does…

[lirui-apache]

…n't work with HiveCatalog

What is the purpose of the change

Fix the issue that generic temporary table can't be used with hive catalog

Brief change log

• Avoid using catalog table factory for temporary tables
• Add test cases

Verifying this change

Existing and added test cases

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? N/A

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1df875a (Fri Aug 21 12:22:33 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 6656a1f Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[JingsongLi]

This PR changed behavior: Planner use Java SPI to load temporary source/sink instead of Catalog.getTableFactory.
I think it is the right work to do, but I think this can be discussed in the dev ML first:

• should we change this behavior?
• should this be a bug to be fixed in 1.11 and 1.10?
  CC: @dawidwys @wuchong

[dawidwys]

Personally I am not convinced this is a good behaviour. I think temporary tables should use the factory of the catalog they were registered in.

Imo if hive cannot deal with such tables, it should fall back in the factory to the SPI approach. As far as I am concerned it is a Hive shortcoming.

[lirui-apache]

@JingsongLi @dawidwys Could you please help review this PR?

[JingsongLi]

Can you create separate PR for isTemporary flag?

[lirui-apache]

@JingsongLi I have separated the changes to planner from those to the hive connector.

[JingsongLi]

Not only source, sink too.
I can see the bug in HiveDynamicTableFactory because not remove old method.

[lirui-apache]

@JingsongLi I have updated the sink method too. Please take another look.

[JingsongLi]

Thanks @lirui-apache for the contribution, looks good to me.