[FLINK-17016][runtime] Integrate pipelined region scheduling #13284

zhuzhurk · 2020-08-31T09:33:04Z

What is the purpose of the change

This PR is to integrate pipelined region scheduling with DefaultScheduler.
A new config option "jobmanager.scheduler.scheduling-strategy" is introduced to control whether to use the new "region" scheduling or to use the "legacy" eager/lazy-from-sources scheduling.
This change is based on #13181 and #13321

Brief change log

Change scheduling strategy for ScheduleMode.LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST
Fix breaking tests due to insufficient slots

Verifying this change

Added integration tests

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2020-08-31T09:35:11Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6e68f6b (Mon Aug 31 09:35:10 UTC 2020)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-08-31T09:55:03Z

CI report:

6af35bf UNKNOWN
acc8ba0 UNKNOWN
b50f961 UNKNOWN
a687e9a Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

zhuzhurk · 2020-09-01T03:56:47Z

The failed e2e test "Elasticsearch (v6.3.1) sink" is a known issue FLINK-19093 which is unrelated to this change.
Re-run the tests.

azagrebin

Thanks for opening the PR @zhuzhurk
I think it is good, I left some smaller comments

flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java

...-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocatorFactory.java

flink-tests/src/test/java/org/apache/flink/test/scheduling/PipelinedRegionSchedulingITCase.java

flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java

flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactory.java

flink-tests/src/test/java/org/apache/flink/test/scheduling/PipelinedRegionSchedulingITCase.java

flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java

flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java

azagrebin

Thanks for addressing comments @zhuzhurk
The PR looks good to me, only minor comments. There are test failures though

azagrebin · 2020-09-09T15:30:06Z

flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactoryTest.java

@@ -35,7 +35,7 @@
 import static org.junit.Assert.assertThat;

 /**
- * Tests for {@link DefaultSchedulerFactory}.
+ * Tests for {@link DefaultSchedulerComponents}.
 */
 public class DefaultSchedulerFactoryTest extends TestLogger {


Suggested change

public class DefaultSchedulerFactoryTest extends TestLogger {

public class DefaultSchedulerComponentsFactoryTest extends TestLogger {

azagrebin · 2020-09-09T15:30:46Z

flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactoryTest.java

@@ -35,7 +35,7 @@
 import static org.junit.Assert.assertThat;

 /**
- * Tests for {@link DefaultSchedulerFactory}.
+ * Tests for {@link DefaultSchedulerComponents}.


Suggested change

* Tests for {@link DefaultSchedulerComponents}.

* Tests for {@link DefaultSchedulerComponents#createSchedulerComponents}.

azagrebin · 2020-09-09T15:32:41Z

flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerComponents.java

+import java.util.function.Consumer;
+
+/**
+ * Components to create a {@link DefaultScheduler}.


Suggested change

* Components to create a {@link DefaultScheduler}.

* Components to create a {@link DefaultScheduler} which depend on the configured {@link JobManagerOptions#SCHEDULING_STRATEGY}.

zhuzhurk · 2020-09-10T08:55:20Z

The commits to "enabled pipelined region scheduling by default" are dropped.
Will enable pipelined region scheduling by default in a separate task FLINK-19189, after we have verified the new scheduling is working well.

…lined region scheduling

…tegy It can be enabled via config option "jobmanager.scheduler.scheduling-strategy=region"

azagrebin

Thanks for address my comments @zhuzhurk LGTM

zhuzhurk · 2020-09-11T14:22:55Z

Thanks for reviewing! @azagrebin
Merging.

rmetzger added the review=description? label Aug 31, 2020

zhuzhurk mentioned this pull request Aug 31, 2020

[WIP][FLINK-17016][runtime] Change blink planner batch jobs to run with pipelined region scheduling #12540

Closed

rmetzger added the component=Runtime/Coordination label Aug 31, 2020

azagrebin reviewed Sep 1, 2020

View reviewed changes

zhuzhurk force-pushed the FLINK_17016_enable_pipelined_scheduling branch 2 times, most recently from 21bf743 to e5a5f7d Compare September 2, 2020 11:30

zhuzhurk changed the title ~~[FLINK-17016][runtime] Change blink planner batch jobs to run with pipelined region scheduling~~ [FLINK-17016][runtime] Enable pipelined region scheduling Sep 3, 2020

zhuzhurk force-pushed the FLINK_17016_enable_pipelined_scheduling branch 6 times, most recently from 9ab00d3 to e95e0ab Compare September 8, 2020 09:58

azagrebin reviewed Sep 8, 2020

View reviewed changes

zhuzhurk force-pushed the FLINK_17016_enable_pipelined_scheduling branch from e95e0ab to acc8ba0 Compare September 9, 2020 08:27

azagrebin reviewed Sep 9, 2020

View reviewed changes

zhuzhurk force-pushed the FLINK_17016_enable_pipelined_scheduling branch from 95fb9ba to b50f961 Compare September 10, 2020 08:45

zhuzhurk changed the title ~~[FLINK-17016][runtime] Enable pipelined region scheduling~~ [FLINK-17016][runtime] Integrate pipelined region scheduling Sep 10, 2020

zhuzhurk added 2 commits September 10, 2020 17:00

[hotfix] Fix checkstyle violations in JobGraph and JobGraphTest

7d71806

[FLINK-17016][runtime] Use SlotSharingExecutionSlotAllocator for pipe…

d7c66c8

…lined region scheduling

zhuzhurk force-pushed the FLINK_17016_enable_pipelined_scheduling branch from b50f961 to e62b168 Compare September 10, 2020 09:00

[FLINK-17016][runtime] Enable to use pipelined region scheduling stra…

a687e9a

…tegy It can be enabled via config option "jobmanager.scheduler.scheduling-strategy=region"

zhuzhurk force-pushed the FLINK_17016_enable_pipelined_scheduling branch from e62b168 to a687e9a Compare September 10, 2020 12:34

azagrebin approved these changes Sep 11, 2020

View reviewed changes

zhuzhurk merged commit 4df2295 into apache:master Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-17016][runtime] Integrate pipelined region scheduling #13284

[FLINK-17016][runtime] Integrate pipelined region scheduling #13284

zhuzhurk commented Aug 31, 2020 •

edited

flinkbot commented Aug 31, 2020

flinkbot commented Aug 31, 2020 •

edited

zhuzhurk commented Sep 1, 2020

azagrebin left a comment

azagrebin left a comment

azagrebin Sep 9, 2020

zhuzhurk Sep 10, 2020

azagrebin Sep 9, 2020

zhuzhurk Sep 10, 2020

azagrebin Sep 9, 2020

zhuzhurk Sep 10, 2020

zhuzhurk commented Sep 10, 2020

azagrebin left a comment

zhuzhurk commented Sep 11, 2020

	public class DefaultSchedulerFactoryTest extends TestLogger {
	public class DefaultSchedulerComponentsFactoryTest extends TestLogger {

	* Tests for {@link DefaultSchedulerComponents}.
	* Tests for {@link DefaultSchedulerComponents#createSchedulerComponents}.

	* Components to create a {@link DefaultScheduler}.
	* Components to create a {@link DefaultScheduler} which depend on the configured {@link JobManagerOptions#SCHEDULING_STRATEGY}.

[FLINK-17016][runtime] Integrate pipelined region scheduling #13284

[FLINK-17016][runtime] Integrate pipelined region scheduling #13284

Conversation

zhuzhurk commented Aug 31, 2020 • edited

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Aug 31, 2020

Automated Checks

Review Progress

flinkbot commented Aug 31, 2020 • edited

CI report:

zhuzhurk commented Sep 1, 2020

azagrebin left a comment

Choose a reason for hiding this comment

azagrebin left a comment

Choose a reason for hiding this comment

azagrebin Sep 9, 2020

Choose a reason for hiding this comment

zhuzhurk Sep 10, 2020

Choose a reason for hiding this comment

azagrebin Sep 9, 2020

Choose a reason for hiding this comment

zhuzhurk Sep 10, 2020

Choose a reason for hiding this comment

azagrebin Sep 9, 2020

Choose a reason for hiding this comment

zhuzhurk Sep 10, 2020

Choose a reason for hiding this comment

zhuzhurk commented Sep 10, 2020

azagrebin left a comment

Choose a reason for hiding this comment

zhuzhurk commented Sep 11, 2020

zhuzhurk commented Aug 31, 2020 •

edited

flinkbot commented Aug 31, 2020 •

edited