[FLINK-19049][table] Fix validation of table functions in projections

[twalthr]

What is the purpose of the change

Validates that table functions cannot be used at locations of scalar functions.

Brief change log

Update validation in both CorrelateCodeGenerator and CalcCodeGenerator.

Verifying this change

This change is already covered by existing tests, such as FunctionITCase.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper:no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 402986d (Mon Aug 31 12:05:43 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 402986d Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[aljoscha]

The changes look good but this doesn't address the initially reported issue that exceptions are shadowed by not using execInsertSqlAndWaitResult() as you suggested. Or does it?

[aljoscha]

Nice use of matchers!

[twalthr]

The old exception was a runtime NullPointerException that is not covered by just running execute() without waiting for job completion. This was a mistake in the test. With this PR we can produce an exception in pre-flight phase. So calling execInsertSqlAndWaitResult is not necessary anymore as we fail earlier. Btw we will have a better API for waiting shortly. I reviewed it yesterday: #12688

[aljoscha]

Perfect! This is good to go then. 👌