New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode #13287
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2557b8a (Mon Aug 31 14:00:22 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM only one minor comment
* @deprecated The code analysis code has been removed and this enum has no effect. | ||
* <b>NOTE</b> It can not be removed from the codebase for now, because it had been serialized as part | ||
* of the {@link ExecutionConfig} which in turn had been serialized as part of the {@link PojoSerializer}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note when exactly we can drop this class. After dropping support for 1.8 savepoints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Removed the ExecutionConfig#get/setCodeAnalysisMode and related classes. We must leave the CodeAnalysisMode enum for now as it is required for java serialization of PojoSerializer.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation