New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18598][python][docs] Add instructions for asynchronous execute in PyFlink doc. #13295
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9f2e570 (Tue Sep 01 08:27:05 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuiqiangchen Thanks a lot for the PR. I only left a minor comment.
docs/dev/python/faq.md
Outdated
@@ -52,6 +52,19 @@ $ source venv/bin/activate | |||
$ python xxx.py | |||
{% endhighlight %} | |||
|
|||
**Note:** When performing asynchronous instructions in a LocalStreamEnvironment, remember to block the process, or it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Note:** When performing asynchronous instructions in a LocalStreamEnvironment, remember to block the process, or it | |
**Note:** If you run jobs in mini-cluster asynchronously, you need to make use of `JobClient` to wait for jobs to finish. |
@HuangXingBo Thank you for your comments, I have updated the PR according to your comments, please have a look. |
@shuiqiangchen Thanks for the update. LGTM |
docs/dev/python/faq.md
Outdated
@@ -52,6 +52,20 @@ $ source venv/bin/activate | |||
$ python xxx.py | |||
{% endhighlight %} | |||
|
|||
**Note:** When running jobs in mini-cluster asynchronously, remember to get a `JobClient` to wait for the execution to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Note:** When running jobs in mini-cluster asynchronously, remember to get a `JobClient` to wait for the execution to | |
**Note:** When executing jobs in mini-cluster asynchronously (e.g. TableEnvironment.execute_sql, StatementSet.execute, etc in the Python Table API; StreamExecutionEnvironment.execute_async in the Python DataStream API), remember to wait for the execution to |
@dianfu Highly appreciate for your suggestions, I have updated the PR, please have a look. |
38a9a93
to
0080463
Compare
…job execution to finish when using asynchronous APIs This closes #13295.
What is the purpose of the change
Add instructions for asynchronous execute in PyFlink doc
Brief change log
Verifying this change
This pull request is a documentation enhancement without test case coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: ( no)Documentation