Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15974][python] Support to use the Python UDF directly in the Python Table API #13325

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Sep 4, 2020

What is the purpose of the change

This pull request add support to use the Python UDF directly in the Python Table API. E.g. for Python UDF inc, users could use it directly in the Python Table API: tab.select(inc(tab.a)).insert_into("sink")

Brief change log

  • Add call method in UserDefinedFunctionWrapper which will allow to call the user-defined function directly in the Python Table API program
  • Improve expressions.call method to support TableFunction in the old planner.
  • Fix FlinkTypeFactory which doesn't works well with the old Decimal TypeInformation in blink planner.
  • Update the tests in test_udf.py, test_udtf.py, test_pandas_udf.py to use this feature.

Verifying this change

This change is already covered by the updated existing tests test_udf.py, test_pandas_udf.py, etc.*.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (Will add documentation in a separate PR)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 4, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 26abf1e (Fri Sep 04 05:34:06 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 4, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@WeiZhong94 WeiZhong94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianfu Thanks for your PR! Look good overall, just some minor comments.

else:
return f.java_user_defined_function()

expressions_clz = gateway.jvm.Class \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be replaced by pyflink.util.utils.load_java_class()?

@@ -184,6 +184,10 @@ def __init__(self, func, input_types, deterministic=None, name=None):
self._deterministic = deterministic if deterministic is not None else (
func.is_deterministic() if isinstance(func, UserDefinedFunction) else True)

def __call__(self, *args):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a type hint?

@dianfu
Copy link
Contributor Author

dianfu commented Sep 4, 2020

@WeiZhong94 Thanks for the review. Updated the PR.

@dianfu dianfu merged commit bffc61a into apache:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants