-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15974][python] Support to use the Python UDF directly in the Python Table API #13325
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 26abf1e (Fri Sep 04 05:34:06 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianfu Thanks for your PR! Look good overall, just some minor comments.
else: | ||
return f.java_user_defined_function() | ||
|
||
expressions_clz = gateway.jvm.Class \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be replaced by pyflink.util.utils.load_java_class()?
flink-python/pyflink/table/udf.py
Outdated
@@ -184,6 +184,10 @@ def __init__(self, func, input_types, deterministic=None, name=None): | |||
self._deterministic = deterministic if deterministic is not None else ( | |||
func.is_deterministic() if isinstance(func, UserDefinedFunction) else True) | |||
|
|||
def __call__(self, *args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a type hint?
@WeiZhong94 Thanks for the review. Updated the PR. |
What is the purpose of the change
This pull request add support to use the Python UDF directly in the Python Table API. E.g. for Python UDF inc, users could use it directly in the Python Table API: tab.select(inc(tab.a)).insert_into("sink")
Brief change log
Verifying this change
This change is already covered by the updated existing tests test_udf.py, test_pandas_udf.py, etc.*.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation