[FLINK-2979] Fix RollingSink truncate for Hadoop 2.7 #1336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljoscha
force-pushed
the
rolling-sink-fix
branch
2 times, most recently
from
699af98
to
20f4ed8
Compare
The problem was, that truncate is asynchronous and the RollingSink was not taking this into account. Now it has a loop after the truncate call that waits until the file is actually truncated. This also changes the Hadoop 2.6 travis build to 2.7, instead.
aljoscha
force-pushed
the
rolling-sink-fix
branch
from
20f4ed8
to
d8afdaa
Compare
|
Manually merged |
|
Can you also merge this into the 0.10 branch, so the 0.10.1 release will get the fix? |
|
Already done. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was, that truncate is asynchronous and the RollingSink was
not taking this into account.
Now it has a loop after the truncate call that waits until the file is
actually truncated.
This also changes the Hadoop 2.6 travis build to 2.7, instead.