Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-19166][table-runtime] StreamingFileWriter should register Listener before the initialization of buckets #13363

Merged
merged 1 commit into from Sep 9, 2020

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

For HiveStreamingSink & FileSystemSink in Table/SQL, partition commit make partition visible for downstream Hive/Spark engines.
But due to FLINK-19166, will lose some partitions to commit after Job failover in some cases, especially for short partitions.
In the user's opinion, the data is lost, which does not conform to exactly-once.

This due to FLINK-18110, in FLINK-18110, it has fixed Buckets, but forgot fixing StreamingFileWriter , it should register Listener before the initialization of buckets, otherwise, will loose listening too.

Brief change log

  • Modify StreamingFileWriter.initializeState, register listener in advance

Verifying this change

StreamingFileWriterTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): (no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no
  • The S3 file system connector: (no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 9, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit beb8f3f (Wed Sep 09 09:36:29 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 9, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thanks @JingsongLi for fix this issue! LGTM!

@zhuzhurk
Copy link
Contributor

zhuzhurk commented Sep 9, 2020

Thanks for the fix @JingsongLi and thanks for reviewing it @gaoyunhaii
As synced online, I will do the merge

@zhuzhurk zhuzhurk merged commit 03fd819 into apache:master Sep 9, 2020
@JingsongLi JingsongLi deleted the partition_bug branch November 5, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants