[FLINK-19166][table-runtime] StreamingFileWriter should register Listener before the initialization of buckets #13363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For HiveStreamingSink & FileSystemSink in Table/SQL, partition commit make partition visible for downstream Hive/Spark engines.
But due to FLINK-19166, will lose some partitions to commit after Job failover in some cases, especially for short partitions.
In the user's opinion, the data is lost, which does not conform to exactly-once.
This due to FLINK-18110, in FLINK-18110, it has fixed Buckets, but forgot fixing StreamingFileWriter , it should register Listener before the initialization of buckets, otherwise, will loose listening too.
Brief change log
StreamingFileWriter.initializeState
, register listener in advanceVerifying this change
StreamingFileWriterTest
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation